This repository was archived by the owner on Sep 26, 2023. It is now read-only.
documenting some limitations#11
Open
vielmetti wants to merge 3 commits intoharthur:masterfrom
vielmetti:master
Open
documenting some limitations#11vielmetti wants to merge 3 commits intoharthur:masterfrom vielmetti:master
vielmetti wants to merge 3 commits intoharthur:masterfrom
vielmetti:master
Conversation
Document line length, symlink limitations
Longline.txt is intended as a test file to validate correctness when lines are longer than a minimum length.
Add a warning about the "chars per line" limit; I can't tell from a first read of the code if the replace has a limit or not in practice.
Owner
|
Thanks for bringing this up. I'll merge some of these notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the limitations I see are
I documented both of those. I'm not so sure about the second, but I added a test file with some lines longer than "limit" (400) so that there's a test that could be done.